Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Jenkinsfile diffs to archetype #58

Merged

Conversation

MarkEWaite
Copy link
Contributor

Reduce Jenkinsfile diffs to archetype

Use the Jenkins plugin archetype as much as possible as we can so that the differences to the archetype are clear and intentionally used.

Tests with Java 21 on Linux and Java 17 on Windows. Accepts that tests on Java 11 are redundant since we've not detected relevant issues that are specific to Java 11.

Testing done

Confirmed that tests pass on Linux with Java 17 and Java 21.

Rely on ci.jenkins.io to test Windows.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Use the Jenkins plugin archetype as much as possible as we can so that
the differences to the archetype are clear and intentionally used.

Tests with Java 21 on Linux and Java 17 on Windows.  Accepts that tests
on Java 11 are redundant since we've not detected relevant issues that
are specific to Java 11.

Confirmed that tests pass on Linux with Java 17 and Java 21.

Rely on ci.jenkins.io to test Windows.

Includes forkCount setting because it improves test performance on
ci.jenkins.io and reduces cost on ci.jenkins.io.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort label Aug 27, 2023
@MarkEWaite MarkEWaite merged commit dd4f8d8 into jenkinsci:master Aug 27, 2023
@MarkEWaite MarkEWaite deleted the use-Jenkinsfile-from-archetype branch August 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant