-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live theme switching support #11
Conversation
@timbrown5 FYI material theme is looking a little broken on recent weeklies due to some icon changes :). But this is unrelated to that |
<revision>0.4.1</revision> | ||
<changelist>-SNAPSHOT</changelist> | ||
<jenkins.version>2.289.1</jenkins.version> | ||
<jenkins.version>2.336</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this plugin replaces most of the older Jenkins icons This needs to be pinned for a family of releases.
0.3.x - Supports pre 2.289.1 (specifically before Add modern icons: build status and weather. ([pull 5065](https://github.com/jenkinsci/jenkins/pull/5065), [pull 5392](https://github.com/jenkinsci/jenkins/pull/5392)
))
0.4.x - supports 2.289.1
+ (unless there are significant Jenkins Icon changes).
0.5.x - will support the next big UI change (possible jenkinsci/jenkins#6307).
My hope is that by doing this I can fix critical issues for users stuck on older Jenkins versions, whilst also not breaking any new icon changes (although it sounds like it's a bit broken on recent Jenkins releases?).
As such, can you leave this as 2.289.1
, so it's the minimum supported version?
That said, if this version update is required to support dependencies (e.g. Theme manager) then can you change the version to 0.5.0 (and then 0.6.x will need to support the next UI change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's required https://github.com/jenkinsci/theme-manager-plugin/blob/795dd3b2c8d2a7a89a7e86f47c231bd271fc4141/pom.xml#L17
Checkbox structure changed in 2.335 and there was an improvement in 2.336 required for theme manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<revision>0.4.1</revision> | ||
<changelist>-SNAPSHOT</changelist> | ||
<jenkins.version>2.289.1</jenkins.version> | ||
<jenkins.version>2.336</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add live theme switching support
Add live theme switching support
See jenkinsci/theme-manager-plugin#75
All themes are now loaded on every page, the active theme is controlled by a
data
attribute on thehtml
element.fyi @timbrown5
Pretty much ready now just need to drop core requirement down