Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live theme switching support #11

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Conversation

timja
Copy link
Member

@timja timja commented Feb 21, 2022

See jenkinsci/theme-manager-plugin#75

All themes are now loaded on every page, the active theme is controlled by a data attribute on the html element.

fyi @timbrown5

Pretty much ready now just need to drop core requirement down

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@timja timja marked this pull request as ready for review February 24, 2022 08:29
@timja timja requested a review from timbrown5 February 24, 2022 08:29
@timja
Copy link
Member Author

timja commented Feb 24, 2022

@timbrown5 FYI material theme is looking a little broken on recent weeklies due to some icon changes :).

But this is unrelated to that

<revision>0.4.1</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.289.1</jenkins.version>
<jenkins.version>2.336</jenkins.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this plugin replaces most of the older Jenkins icons This needs to be pinned for a family of releases.
0.3.x - Supports pre 2.289.1 (specifically before Add modern icons: build status and weather. ([pull 5065](https://github.com/jenkinsci/jenkins/pull/5065), [pull 5392](https://github.com/jenkinsci/jenkins/pull/5392)))
0.4.x - supports 2.289.1+ (unless there are significant Jenkins Icon changes).
0.5.x - will support the next big UI change (possible jenkinsci/jenkins#6307).

My hope is that by doing this I can fix critical issues for users stuck on older Jenkins versions, whilst also not breaking any new icon changes (although it sounds like it's a bit broken on recent Jenkins releases?).
As such, can you leave this as 2.289.1, so it's the minimum supported version?

That said, if this version update is required to support dependencies (e.g. Theme manager) then can you change the version to 0.5.0 (and then 0.6.x will need to support the next UI change).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required https://github.com/jenkinsci/theme-manager-plugin/blob/795dd3b2c8d2a7a89a7e86f47c231bd271fc4141/pom.xml#L17

Checkbox structure changed in 2.335 and there was an improvement in 2.336 required for theme manager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just checking if this version change will cause issues for #13 (just to know the order of merging).
The likelihood is that someone will need to update their PR. I will prefer yours you were first (unless #13 is stuck on an older version).

pom.xml Outdated Show resolved Hide resolved
@timja timja requested a review from timbrown5 March 3, 2022 14:13
@timbrown5 timbrown5 mentioned this pull request Mar 14, 2022
6 tasks
<revision>0.4.1</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.289.1</jenkins.version>
<jenkins.version>2.336</jenkins.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just checking if this version change will cause issues for #13 (just to know the order of merging).
The likelihood is that someone will need to update their PR. I will prefer yours you were first (unless #13 is stuck on an older version).

@timbrown5 timbrown5 merged commit d8fbe52 into jenkinsci:master Mar 15, 2022
@timja timja deleted the namespaced branch March 15, 2022 11:24
jonesbusy referenced this pull request in jonesbusy/material-theme-plugin Mar 19, 2022
Add live theme switching support
jonesbusy referenced this pull request in jonesbusy/material-theme-plugin Mar 19, 2022
Add live theme switching support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants