-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding green and yellow theme colors, formatting edits for readability & consistency #52
Conversation
…ormatting the css files a bit for better readability with the extra colors being added
I think you need to add your CSS files to the root action as above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add the new CSS items to the root action, see:
#52 (comment)
Woops sorry about that, I think that should do it |
@timbrown5 looks like something went wrong in the release process and its not available to the jenkins plugin manager even tho github is showing the correct release version. |
I think a build is available, but it's got the wrong version number
0.5.2-rc100.
…On Sat, 1 Oct 2022, 00:47 Trevor, ***@***.***> wrote:
@timbrown5 <https://github.com/timbrown5> looks like something went wrong
in the release process and its not available to the jenkins plugin manager
even tho github is showing the correct release version.
—
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB54FBIRVVRPZRGROWBDWLWA53YPANCNFSM6AAAAAAQNZP2NM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Added a green and yellow themes
Also cleaned up some unused imports and reformatted the css a bit for better readability
Issue: #53
Note
I think I got everything setup for these, happy to modify as needed.
The readability is subjective I understand but consistency is not so thats what I went for.
Consistency was picked based on the first occurrence where each color was on its own line, this read nice and was easier to maintain in my opinion so I used that format for everywhere else. (https://github.com/jenkinsci/material-theme-plugin/blob/master/src/main/webapp/material-theme.css#L113-L116)
We needed these colors for our instances of jenkins that we previously used afonsof/jenkins-material-theme for; which this is based off of! Colors were taken from there, secondary colors are 75% opacity of the primary color.