Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching tests to throw generic Exception #425

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

PereBueno
Copy link
Contributor

Simply changing some tests signature to throw a generic exception, simpler to maintain and avoids merge problems

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@PereBueno PereBueno requested a review from a team as a code owner October 11, 2024 12:33
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.88%. Comparing base (0a76e5d) to head (c98df34).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #425      +/-   ##
============================================
+ Coverage     71.68%   71.88%   +0.20%     
- Complexity      202      206       +4     
============================================
  Files            16       16              
  Lines           890      900      +10     
  Branches        120      126       +6     
============================================
+ Hits            638      647       +9     
+ Misses          188      186       -2     
- Partials         64       67       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtnord jtnord merged commit b409831 into jenkinsci:master Oct 11, 2024
21 checks passed
@olamy olamy added the tests label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants