Add resource attributes lost moving ReconfigurableOpenTelemetry to opentelemetry-api-plugin #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrille-leclerc
added
the
major-bug
6 tasks
cyrille-leclerc
commented
Jul 28, 2024
| <opentelemetry-instrumentation.version>2.5.0</opentelemetry-instrumentation.version> | ||
| <opentelemetry-semconv.version>1.26.0-alpha</opentelemetry-semconv.version> | ||
| <opentelemetry-instrumentation.version>2.6.0</opentelemetry-instrumentation.version> | ||
| <opentelemetry-semconv.version>1.25.0-alpha</opentelemetry-semconv.version> |
There was a problem hiding this comment.
We revert semconv to 1.25 as opentelemetry instrumentations have a dependency on semconv 1.25.
|
@kuisathaverat please review |
timja
reviewed
Jul 29, 2024
|
|
||
| @Test | ||
| public void test_instantiate_instrumented_http_client() { | ||
| ReconfigurableOpenTelemetry openTelemetry = new ReconfigurableOpenTelemetry(); |
There was a problem hiding this comment.
should this be in a try-with-resources?
Suggested change
| ReconfigurableOpenTelemetry openTelemetry = new ReconfigurableOpenTelemetry(); | |
| try (ReconfigurableOpenTelemetry openTelemetry = new ReconfigurableOpenTelemetry()) { |
| ReconfigurableOpenTelemetry openTelemetry = new ReconfigurableOpenTelemetry(); | ||
| HttpClientBuilder httpClientBuilder = ApacheHttpClientTelemetry.create(openTelemetry).newHttpClientBuilder(); | ||
| CloseableHttpClient httpClient = httpClientBuilder.build(); | ||
| System.out.println(httpClient); |
There was a problem hiding this comment.
Is this supposed to assert something?
There was a problem hiding this comment.
yes verify we don't have class loading issues. I'll iterate on the test
| public void test_instantiate_instrumented_data_source() { | ||
| try (ReconfigurableOpenTelemetry openTelemetry = new ReconfigurableOpenTelemetry()) { | ||
| DataSource dataSource = JdbcTelemetry.create(openTelemetry).wrap(new BasicDataSource()); | ||
| System.out.println(dataSource); |
There was a problem hiding this comment.
Is this supposed to assert something?
There was a problem hiding this comment.
Ditto, verify class loading issues. I'll iterate on these tests
kuisathaverat
approved these changes
Jul 29, 2024
kuisathaverat
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resource attributes lost moving ReconfigurableOpenTelemetry to opentelemetry-api-plugin.
Default
service.name,service.namespace,service.version,service.instance.id, andjenkins.urlwhere no longer populated if default values set by the GUI were mising (eg config as code use cases).Fix for:
Testing done
Submitter checklist