Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using ReconfigurableOpenTelemetry instance through @Inject #14

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Support using ReconfigurableOpenTelemetry instance through @Inject #14

merged 1 commit into from
Aug 27, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Aug 8, 2024 •
edited
Loading

Support using ReconfigurableOpenTelemetry instance through @Inject in addition to the traditional Jenkins hudson.ExtensionList#lookup().

Implemented introducing a com.google.inject.AbstractModule annotated with @Extension

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc cyrille-leclerc marked this pull request as ready for review August 26, 2024 14:38
@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner August 26, 2024 14:38
@cyrille-leclerc
Copy link
Contributor Author

@kuisathaverat please review

@cyrille-leclerc cyrille-leclerc added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 27, 2024
@cyrille-leclerc cyrille-leclerc merged commit 85785bc into main Aug 27, 2024
18 checks passed
@cyrille-leclerc cyrille-leclerc deleted the support-at-inject branch August 27, 2024 17:19
@cyrille-leclerc cyrille-leclerc mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees
No one assigned
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrille-leclerc @kuisathaverat