Export Otel configuration in shell steps: OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS …

[cyrille-leclerc]

Export Otel configuration in shell steps OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS...

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

Tested with https://github.com/cyrille-leclerc/opentelemetry-maven-extension

[v1v]

is it possible to mask those env variables to avoid exposing them?

For instance:

• I built a shared library step to expose those env variables and mask them in Set OTEL_EXPORTER_OTLP_HEADERS elastic/apm-pipeline-library#1234 and Provide OTEL context elastic/apm-pipeline-library#1218

[cyrille-leclerc]

Great idea @v1v. I propose to do it as a subsequent milestone. In the meantime, people can disable the feature if needed. Would that work for you?

[v1v]

Missing the new configuration in the https://github.com/jenkinsci/opentelemetry-plugin#configuration-as-code section

[v1v]

I propose to do it as a subsequent milestone. In the meantime, people can disable the feature if needed. Would that work for you?

What do you think to set it false meantime? Then, whoever enables it will know the security implications

Suggested change

	private boolean dontExportOtelConfigurationAsEnvironmentVariables;
	private boolean dontExportOtelConfigurationAsEnvironmentVariables = false;

[cyrille-leclerc]

I wanted to enable this by default as I feel it's not a security problem in most cases because it's just telemetry.

false is the default value as the config attribute is "Don't export Otel Configuration as Environment Variables". Due to the way Jenkins XStream works, there would be some work to make it true by default, I would define the opposite variable instead: exportOtelConfigurationAsEnvironmentVariables.

[cyrille-leclerc]

FYI I'm trying to mask credentials in the console: https://groups.google.com/g/jenkinsci-dev/c/FMl_plHvPv8

[cyrille-leclerc]

@v1v I followed your recommendation and I disabled the feature by default to ensure there is no surprise.