Fixing findbugs warnings after plugin pom upgrade #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
previously approved these changes
Feb 12, 2018
svanoort
previously approved these changes
Feb 12, 2018
…plugin into findbugs
So the unstableTotalAll actually wasn't applied.
|
Build failure was expected. Well I was expecting it to be unstable but at least not successful. |
rsandell
changed the title
rsandell
dismissed stale reviews from abayer and svanoort
New commits, needs rereview
abayer
approved these changes
Feb 14, 2018
svanoort
reviewed
Feb 14, 2018
| @@ -76,6 +77,7 @@ private SimpleManifest parseText(String text) throws IOException { | |||
| return new SimpleManifest(manifest); | |||
| } | |||
|
|
|||
| @SuppressFBWarnings(value = "RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", justification = "I don't understand what/where it is.") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The excludesFile is not taking effect as it is configured in plugin-pom, so needed a full config in here.