Deprecating readMavenPom and writeMavenPom steps #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also @abayer @dwnusbaum |
abayer
approved these changes
Aug 16, 2018
dwnusbaum
approved these changes
Aug 16, 2018
|
ping @rsandell |
|
@jglick I don't want to deprecate these steps. But haven't been able to formulate an explanation that I think is satisfactory for you yet ;) I have users that want to keep them around and I also made sure that they will stay working when I designed the remote step execution for off master :) |
|
Well, your call. |
|
OK, closing for above reasons |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide people to not use them. There are problems like JENKINS-40514, the mess in #46, and above all the likely incompatibility with off-master execution. @svanoort @rsandell