Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74095] [JENKINS-74096] [JENKINS-74097] [JENKINS-74099] Remove legacy checkUrl handlers #146

Merged

Conversation

shlomomdahan
Copy link
Contributor

@shlomomdahan shlomomdahan commented Nov 19, 2024

Jira:

What has been done

  1. Remove the legacy onClick handlers as part of effort to improve CSP compatibility across Jenkins

Freestyle Project:
Before Changes
After Changes

Pipeline Project:
After Changes

How to test - Freestyle Project

  1. Create a freestyle project
  2. In post build steps, select: Plot build data
  3. Add the data series file and check validation triggers.
    Screenshot 2024-11-19 at 11 57 50 AM

How to test - Pipeline Project

  1. Create Pipeline Project
  2. In configuration select Pipeline Syntax and navigate to snipper generator.
  3. In Sample Step selector, select: Plot: Plot build data
  4. add CSV, Properties, and XML Series data.
  5. Change the Series file name and verify in network tab that correct requests are sent.

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • Pull Request is marked with appropriate label (see .github/release-drafter.yml)
  • JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
  • For dependency updates: links to external changelogs and, if possible, full diffs

@yaroslavafenkin
Copy link

yaroslavafenkin commented Nov 20, 2024

Remove legacy inline onClick handlers

Do you mean checkUrls, not onClick?

[JENKINS-74095-74096-74097-74099]

I won't find anything if I search git log output e.g. for JENKINS-74096 :(

@shlomomdahan shlomomdahan changed the title [JENKINS-74095-74096-74097-74099] Remove legacy inline onClick handlers [JENKINS-74095-74096-74097-74099] Remove legacy checkUrl handlers Nov 21, 2024
@shlomomdahan shlomomdahan changed the title [JENKINS-74095-74096-74097-74099] Remove legacy checkUrl handlers [JENKINS-74095] [JENKINS-74096] [JENKINS-74097] [JENKINS-74099] Remove legacy checkUrl handlers Nov 21, 2024
@MarkEWaite MarkEWaite added the bug Bug fix label Nov 25, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit efbb7f5 into jenkinsci:master Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants