Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74098] Remove inline JS script and legacy onClick handler #147

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

shlomomdahan
Copy link
Contributor

Jira: JENKINS-74098

What has been done

  1. Remove the inline JS <script> tag as well as its corresponding legacy onChange handler to improve CSP compatibility.

Screenshots

Before
After

How to test

  1. Create a freestyle project
  2. In Post build actions select Plot build data
  3. In the Plot Group enter a name (ex. "test") and use that same plot group name to create 2 or more plots.
  4. Save the configuration, go to the project page and select Plots from the left hand navigation menu
  5. in the "jump to" selector, select a plot and observe the page jump to the location of that plot

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • Pull Request is marked with appropriate label (see .github/release-drafter.yml)
  • JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
  • For dependency updates: links to external changelogs and, if possible, full diffs

@MarkEWaite MarkEWaite added the bug Bug fix label Nov 25, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 3e73a37 into jenkinsci:master Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants