Trim trailing whitespaces on labels and values

[vgaidarji]

This is a follow up of #45.

What has been done

1. Used trim() on labels and y values
2. Updated tests
3. Added windows node to Jenkins builds
4. Clean up tests and increase test execution time by migration all tests to org.junit and removal of legacy HudsonTestCase from base SeriesTestCase class.

In Windows, if you are trying to create a csv file using echo, you will get trailing whitespace at the end of each line. For example:

echo label1,label2,label3 > output.csv
echo 1,2,3 >> output.csv

output.csv will now contain a trailing space at the end of each line. Now if the user says they want to plot only "label3" (using exclusion/inclusion criteria), the parser will not find a match, because it has captured "label3 " (with a space) as the label for the row.

Screenshots

Debugging in Visual Studio code, I took screenshots of the original code grabbing the trailing space from the new test case I added.

How to test

1. If someone wants to reproduce this on Windows, I used this as a Windows batch script:

set plotfile=test.csv

IF NOT EXIST %plotfile% (
   echo foo,bar,thing > %plotfile%
)

echo %time:~-5%,7,%time:~-2% >> %plotfile%

2. Now try to plot only the last column named "thing" using the plot plugin. It will not get plotted because the plugin only discovers the name "thing " (with space).

Checklist

• Git commits follow best practices
• Build passes in Jenkins
• Appropriate tests or explanation to why this change has no tests
• JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
• For dependency updates: links to external changelogs and, if possible, full diffs

[codecov]

Codecov Report

Merging #52 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
- Coverage     42.06%   41.89%   -0.17%     
+ Complexity      178      176       -2     
============================================
  Files            18       18              
  Lines          1222     1222              
  Branches        186      186              
============================================
- Hits            514      512       -2     
- Misses          644      646       +2     
  Partials         64       64

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/hudson/plugins/plot/CSVSeries.java	49.6% <100%> (-0.79%)	19 <0> (-1)
src/main/java/hudson/plugins/plot/XMLSeries.java	71.32% <0%> (-0.7%)	35% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88cfe6...29898bd. Read the comment docs.

[vgaidarji]

Need to fix tests on Windows node in Jenkins (most probably caused by sh step in pipeline under test):

[2019-06-11T19:20:24.813Z] [ERROR] Tests run: 16, Failures: 15, Errors: 0, Skipped: 0, Time elapsed: 29.378 s <<< FAILURE! - in hudson.plugins.plot.PlotBuilderTest
[2019-06-11T19:20:24.813Z] [ERROR] testWithProperties(hudson.plugins.plot.PlotBuilderTest)  Time elapsed: 1.645 s  <<< FAILURE!
[2019-06-11T19:20:24.813Z] java.lang.AssertionError: 
[2019-06-11T19:20:24.813Z] unexpected build status; build log was:
[2019-06-11T19:20:24.813Z] ------
[2019-06-11T19:20:24.813Z] Started
[2019-06-11T19:20:24.813Z] [Pipeline] node
[2019-06-11T19:20:24.813Z] Running on master in C:\windows\TEMP\jenkinsTests.tmp\jenkins2289443509074702808test\workspace\projectUnderTest
[2019-06-11T19:20:24.813Z] [Pipeline] {
[2019-06-11T19:20:24.813Z] [Pipeline] sh
[2019-06-11T19:20:24.813Z] [C:\windows\TEMP\jenkinsTests.tmp\jenkins2289443509074702808test\workspace\projectUnderTest] Running shell script
[2019-06-11T19:20:24.813Z] [Pipeline] }
[2019-06-11T19:20:24.813Z] [Pipeline] // node
[2019-06-11T19:20:24.813Z] [Pipeline] End of Pipeline
[2019-06-11T19:20:24.813Z] java.io.IOException: Cannot run program "nohup" (in directory "C:\windows\TEMP\jenkinsTests.tmp\jenkins2289443509074702808test\workspace\projectUnderTest"): CreateProcess error=2, The system cannot find the file specified

[vgaidarji]

We can improve tests even more, but refactoring done in this PR already makes them cleaner and better organized.

Changes introduced for trimming are covered with tests and shouldn't bring any issues.

@skelliam I'm going to merge & release these changes soon 🎉