Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Drafter configuration #60

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add Release Drafter configuration #60

merged 1 commit into from
Mar 25, 2020

Conversation

vgaidarji
Copy link
Contributor

@vgaidarji vgaidarji commented Mar 18, 2020

What has been done

  1. Added Release Drafter integration.
    Read more at https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc and https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/.
  2. Configured GitHub labels to be used for Pull Requests for automatic release generation by Release Drafter
  3. Manually created releases for versions published after old Changelog deprecation under https://github.com/jenkinsci/plot-plugin/releases. Followed the same Release Drafter format.

TODO

  • [ ] Backup old Changelog into current repository as markdown file
    Will be addressed in separate PR.

How to test

  1. Will be tested during next release. Release Drafter should create draft release and automatically include labeled PRs

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
  • For dependency updates: links to external changelogs and, if possible, full diffs

@vgaidarji vgaidarji added the feature New feature or improvement label Mar 18, 2020
@vgaidarji vgaidarji self-assigned this Mar 18, 2020
@@ -0,0 +1,5 @@
# see https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc
_extends: .github
version-template: $MAJOR.$MINOR.$PATCH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin still uses full semver and not major.minor as other Jenkins plugins.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #60 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     43.38%   43.38%           
+ Complexity      191      190    -1     
=========================================
  Files            18       18           
  Lines          1263     1263           
  Branches        192      192           
=========================================
  Hits            548      548           
  Misses          651      651           
  Partials         64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54423d6...c554816. Read the comment docs.

@vgaidarji vgaidarji merged commit ee8ed18 into master Mar 25, 2020
@vgaidarji vgaidarji deleted the add-release-drafter branch March 25, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant