-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-20679] - Inject Minimum-Java-Version into the plugin manifest #134
[JENKINS-20679] - Inject Minimum-Java-Version into the plugin manifest #134
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems extremely confusing to me. Why can we not just say it always injects versions in the now-preferred format: |
It follows Java specification formats in https://openjdk.java.net/jeps/223 (new ones for modern Javas and old ones for 8 and older) |
@jenkinsci/java11-support should be ready to go |
Downstream of jenkinsci/maven-hpi-plugin#75 . It is a more simple version of #133 which should unblock the feature while
java.level=11
is not fully supported. So you still build plugins which are formally Java 8 compliant (source/target), but you can require Java 11 due to whatever reason.1.8
or1.7
11
for Java 11. Example: Enable test automation for Java 11 and newer Jenkins Core versions label-verifier-plugin#4 and Prepare an experimental release with Java 11 compatibility workflow-support-plugin#82Consumer of the pull request: jenkins-infra/update-center2#253
@jenkinsci/java11-support