Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [SEI-7025]: Removed validation check for jenkins user name and t… #19

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: [SEI-7025]: Removed validation check for jenkins user name and t… #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
</profiles>

<properties>
<revision>1.0.31</revision>
<revision>1.0.32</revision>
<!-- <changelist>999999-SNAPSHOT</changelist> -->
<changelist></changelist>
<product.build.sourceEncoding>UTF-8</product.build.sourceEncoding>
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/io/jenkins/plugins/propelo/job_reporter/service/JobRunCompleteDataService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@
if(jobRunDetail == null){
return null;
}
if(StringUtils.isEmpty(plugin.getJenkinsUserName())
|| plugin.getJenkinsUserToken() == null
|| StringUtils.isEmpty(plugin.getJenkinsUserToken().getPlainText())) {
return null;

Check warning on line 96 in src/main/java/io/jenkins/plugins/propelo/job_reporter/service/JobRunCompleteDataService.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 93-96 are not covered by tests
}

BlueOceanRestClient restClient = new BlueOceanRestClient(plugin.getJenkinsBaseUrl(), plugin.getJenkinsUserName(), plugin.getJenkinsUserToken().getPlainText(), plugin.isTrustAllCertificates(), mapper, proxyConfig);

Expand Down
3 changes: 1 addition & 2 deletions ...resources/io/jenkins/plugins/propelo/job_reporter/extensions/LevelOpsMgmtLink/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@
</f:entry>
<f:entry title="Jenkins User Token" description="Jenkins User Token" field="jenkinsUserToken"
help="/plugin/${it.urlName}/help/help-jenkinsUserToken.html">
<f:password value="${it.configuration.jenkinsUserToken}" name="jenkinsUserToken"
checkUrl="'${rootURL}/plugin/${it.urlName}/checkJenkinsUserToken?value='+escape(this.value)" checkMethod="post"/>
<f:password value="${it.configuration.jenkinsUserToken}" name="jenkinsUserToken"/>
</f:entry>

<f:optionalBlock title="Trust All Certificates"
Expand Down
Loading