Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message and AccessControlledMessage public so they can be used by other plugins #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Dec 22, 2019

Does changing access levels need tests?

Looking to add pubsub support to favorites, and while I was doing so, I couldn't figure out how to make my own message type, especially one that didn't broadcast all fav changes that all users did to the entire system (should it do so?)

Submitter checklist

  • [N/A] Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@halkeye
Copy link
Member Author

halkeye commented Dec 22, 2019

@olamy @stephenc @tfennelly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants