Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin parent POM and BOM #101

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Update plugin parent POM and BOM #101

merged 1 commit into from
Apr 24, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 21, 2022

No description provided.

@basil
Copy link
Member Author

basil commented Apr 21, 2022

@GLundh A release of this would facilitate Java 17 PCT testing.

@basil
Copy link
Member Author

basil commented Apr 23, 2022

@rsandell 🙏

@GLundh
Copy link
Member

GLundh commented Apr 24, 2022

I can handle this in the end of the coming week the earliest. But please know that you, @basil, are free to release it yourself too. As a cloudbees employee, you should have the needed access rights?

@GLundh GLundh merged commit 8e9d9ba into jenkinsci:master Apr 24, 2022
@basil
Copy link
Member Author

basil commented Apr 24, 2022

Thanks for merging, @GLundh! I'm not sure where you got that impression from, but it is not accurate. The only people with Artifactory permissions to do releases for a plugin are those who are listed in repository-permissions-updater:

https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-rebuild.yml

There is no generic permission for CloudBees employees.

@GLundh
Copy link
Member

GLundh commented Apr 24, 2022

Apologies! But was not the last (security related) release made by cloudbees (Kevin-CB)?

Anyways, feel free to add yourself to the repository permission yaml. :)

@basil
Copy link
Member Author

basil commented Apr 24, 2022

Apologies! But was not the last (security related) release made by cloudbees (Kevin-CB)?

I can't comment on security releases, which may have a different process. But what I wrote is the case for regular releases.

Anyways, feel free to add yourself to the repository permission yaml. :)

I am not interested in becoming a maintainer of this plugin.

@GLundh
Copy link
Member

GLundh commented Apr 25, 2022

I did not think so. Worth a try, since all requests for new releases comes from cloudbees and I don't work much with Jenkins these days. I'll try a new release sometime this week and then put it up for adoption.

@basil
Copy link
Member Author

basil commented Apr 25, 2022

Worth a try, since all requests for new releases comes from cloudbees

I don't think that's a fair generalization. I have been doing you the favor of keeping your plugin's build up-to-date and testing your plugin for compatibility with other Jenkins plugins in jenkinsci/bom, and I have been doing this since before I joined CloudBees.

All you have to do in order to keep receiving this benefit from me is merge PRs and cut releases. If you set up JEP-229, all you would need to do is apply the right label when merging the PR and the release would be done automatically.

If, on the other hand, you don't want to receive this benefit from me, fine. If you stop merging and releasing PRs and nobody else steps up to maintain this plugin, I will probably just remove this plugin from the compatibility testing matrix in jenkinsci/bom. That would be a net loss for Jenkins users, but the choice is yours.

@GLundh
Copy link
Member

GLundh commented Apr 25, 2022

Hi basil. I'm not trying to be offending or anything. I'm sorry if it came off that way.

I took over the maintenance a couple of years ago, since we (like many other companies) relied on it and it was practically dead. The plugin was in dire need of maintenance. There where quite a few PRs that really needed to be merged.

Since then I have reviewed a lot of code and released quite a few releases. As expected from a maintainer.

What I'm saying is that my role at work has changed a bit, and I do not have time to maintain this plug-in anymore. Most work is done on my spare time. I am just not interested in maintaining this plugin for a lot longer.

Historically, Cloudbees has been asking for a few releases. Often due to security reasons, but also compatibility-releases with new versions of Jenkins. (Which is great) So. I asked about Cloudbees maintaining it, since I figured it was in the company's direct interest, due to the fact that the plugin provides a core feature of Jenkins and have therefore 50k installs. (And most PRs nowadays comes from Cloudbees).

I understand that Cloudbees do not want to pickup this plugin, but as I no longer have time to maintain the plugin I figured the correct process was to put it up for adoption. If it is not, please let me know if there is a better way to proceed.

And to be clear, I'm very happy about all the work you are doing. And I certainly know that rebuilder (and many other plugins) benefit from your work. And the community as a whole. I think this PR is great. I'm just trying to find a solution for this plugin to live on, since the community relies on it.

@basil
Copy link
Member Author

basil commented Apr 25, 2022

I no longer have time to maintain the plugin I figured the correct process was to put it up for adoption. If it is not, please let me know if there is a better way to proceed.

Yes, that is the correct process. We would be sad to see you go, but (as I wrote above) the choice is yours.

@basil basil deleted the pom branch April 25, 2022 20:03
@Wadeck
Copy link

Wadeck commented May 2, 2022

@GLundh Hello, that's an interesting feedback about the perception of CloudBees having the ownership on the plugin ecosystem.

Concerning the security releases, the Jenkins CERT (= Jenkins security team) members have administrator permission on the whole jenkinsci organization, for their security tasks.
Currently, the active CERT members are employed by CloudBees (who is sponsoring the security job), but this is not a required relationship, anyone interested in security could join that team.

The team is led by the elected security officer, currently me, in the past it was Daniel Beck. We are both working for CloudBees but again this is not a requirement at all. It's just that recently there was close to no interest from anyone else to present themselves for the role.

We are trying to ensure the maintainers are pinged / asked / consulted when there is a security release coming. We often give them the possibility to decide if they release it themselves or let us do the release.
In our last interaction, it was a particular case as it's a coordinated releases that involved multiple plugins with the same vulnerabilities.

If you have any questions, please reach out :-)

@basil
Copy link
Member Author

basil commented May 11, 2022

Gentle ping; a release of this would be appreciated! Many thanks again for your efforts.

@GLundh
Copy link
Member

GLundh commented May 12, 2022

Sorry. Lost my disks in a crash. Had to re-setup my jenkins-dev-environment. I'm on it.

@GLundh
Copy link
Member

GLundh commented May 12, 2022

Done. Sorry for the delay!

@basil
Copy link
Member Author

basil commented May 12, 2022

Many thanks! Your diligence is highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants