Add parameterless rebuild option for projects.

[jacobgardner]

Projects now have a checkbox that can allow projects with parameters to bypass the rebuild w/ parameters page and requeue using the exact parameters as before without showing an additional screen.

[buildhive]

Jenkins » rebuild-plugin #45 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

Jenkins » rebuild-plugin #46 SUCCESS
This pull request looks good
(what's this?)

[oleg-nenashev]

Unfortunately, PR won't work for File parameters (due to RebuildPlugin's internals). I propose to merge this PR after fix of the FileParameter. Do you agree, Jacob?

[jacobgardner]

I just tested this and it works with file parameters if "Automatically Rebuild Without Asking For Parameters" is enabled. Otherwise, it works the same as before.

[shemeersulaiman]

Lot of checkstyle errors.Could you please fix it.Sorry for missing it in previous reviews

[shemeersulaiman]

Checkstyle Error info
com/sonyericsson/rebuild/RebuildAction.java
Violation Message Line
Errors Using the '.' form of import should be avoided - hudson.model.. 29
Errors Using the '.' form of import should be avoided - hudson.model.. 32
Errors Duplicate import to line 29 - hudson.model.. 32
Errors Using the '.' form of import should be avoided - org.kohsuke.stapler.. 33
Errors Using the '.' form of import should be avoided - net.sf.json.*. 34
Errors Duplicate import to line 28 - hudson.matrix.MatrixRun. 40
Errors Missing a Javadoc comment. 63
Errors Missing a Javadoc comment. 66
Errors Line has trailing spaces. 186
Infos 'if' is not followed by whitespace. 187
Errors Missing a Javadoc comment. 198
Warnings ')' is followed by whitespace. 264
Warnings ')' is followed by whitespace. 298
Errors Line has trailing spaces. 333
Errors '&&' should be on a new line. 333
Errors Line has trailing spaces. 334
Errors '&&' should be on a new line. 334
Errors Line has trailing spaces. 335
Errors '&&' should be on a new line. 335
Errors Line is longer than 121 characters. 352
Errors Line is longer than 121 characters. 361
Warnings ')' is followed by whitespace. 361
Errors Line has trailing spaces. 410
Errors Missing a Javadoc comment. 411

[buildhive]

Jenkins » rebuild-plugin #53 SUCCESS
This pull request looks good
(what's this?)

[shemeersulaiman]

com/sonyericsson/rebuild/RebuildActionFactory.java
Violation Message Line
Errors Using the '.' form of import should be avoided - hudson.model.. 28
Errors 'if' construct must use '{}'s. 43
Infos 'if' is not followed by whitespace. 43
Warnings ')' is followed by whitespace. 45

com/sonyericsson/rebuild/RebuildCause.java
Violation Message Line
Errors Missing a Javadoc comment. 38

com/sonyericsson/rebuild/RebuildConfiguration.java
Violation Message Line
Errors Missing a Javadoc comment. 36
Errors Variable 'rememberPasswordEnabled' must be private and have accessor methods. 36
Errors '+' should be on a new line. 51
Errors '+' should be on a new line. 52

com/sonyericsson/rebuild/RebuildDescriptor.java
Violation Message Line
Errors Line is longer than 121 characters. 27

com/sonyericsson/rebuild/RebuildProjectActionFactory.java
Violation Message Line
Errors Unused import - java.util.Collections. 34
Errors 'if' construct must use '{}'s. 47
Infos 'if' is not followed by whitespace. 47

com/sonyericsson/rebuild/RebuildSettings.java
Violation Message Line
Warnings ',' is not followed by whitespace. 38
Errors Line has trailing spaces. 39
Errors Missing a Javadoc comment. 40
Errors Name 'auto_rebuild' must match pattern '^[a-z][a-zA-Z0-9]$'. 40
Errors Variable 'auto_rebuild' must be private and have accessor methods. 40
Errors Line has trailing spaces. 41
Errors Missing a Javadoc comment. 42
Errors Name 'auto_rebuild' must match pattern '^[a-z][a-zA-Z0-9]$'. 43
Errors Line has trailing spaces. 46
Errors Missing a Javadoc comment. 47
Errors Name 'getAuto_rebuild' must match pattern '^[a-z][a-zA-Z0-9]*$'. 47
Errors Line has trailing spaces. 50
Errors Missing a Javadoc comment. 51
Errors 'static' modifier out of order with the JLS suggestions. 52
Errors Line has trailing spaces. 57
Errors Line has trailing spaces. 62
Errors ')' is preceded with whitespace. 64
Errors Line has trailing spaces. 67

com/sonyericsson/rebuild/RebuildValidatorTest.java
Violation Message Line
Warnings ')' is followed by whitespace. 62
Warnings ')' is followed by whitespace. 80
Warnings ')' is followed by whitespace. 98
Warnings ')' is followed by whitespace. 117
Errors '100' is a magic number. 185
Warnings ')' is followed by whitespace. 193
Errors Line is longer than 121 characters. 205

com/sonyericsson/rebuild/Rebuilder.java
Violation Message Line
Warnings ')' is followed by whitespace. 53

[oleg-nenashev]

@shemeersulaiman, I suppose you should configure checkstyle and findbugs plugins to fail the build for significant style errors. I have not even seen these warnings :) BuildHive build don't notify about warnings as well (BTW, its build log is quite strange)

Do you expect me or @jacobgardner or me to fix these errors? I suppose that most of them came from previous PRs.

[shemeersulaiman]

@oleg-nenashev OK , I will configure the checkstyle, for the time being you can merge the changes and I will fix it in the master branch

[oleg-nenashev]

Ok

[oleg-nenashev]

It is too late, but...

• Section wraps top sections of job's configs into two parts
• Long title should be moved to the title field of ""

I propose to wrap option into a standalone class, which will be extended by additional options. BTW, it will require backporting options, because this patch has been already released.
Added an issue for both comments: https://issues.jenkins-ci.org/browse/JENKINS-19905