Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-19910] added support for maven metadata plugin #16

Merged
merged 2 commits into from
Nov 15, 2013
Merged

[JENKINS-19910] added support for maven metadata plugin #16

merged 2 commits into from
Nov 15, 2013

Conversation

hrmohr
Copy link
Contributor

@hrmohr hrmohr commented Oct 6, 2013

This pull request adds support for rebuilding projects which uses the maven metadata plugin parameter.

The form includes the same error handling as the original form used by the maven metadata plugin.

@buildhive
Copy link

Jenkins » rebuild-plugin #64 SUCCESS
This pull request looks good
(what's this?)

@oleg-nenashev
Copy link
Member

Hmm... Pull request contains empty file...

@oleg-nenashev
Copy link
Member

If you don't need this fix ASAP, you can wait till release of a new version with #17 . Then, you will be able to add rebuild support into your plugin

@hrmohr
Copy link
Contributor Author

hrmohr commented Oct 7, 2013

What the...

Don't know what went wrong here. I'll look into this when I get home.

On 07/10/2013, at 07.37, Oleg Nenashev notifications@github.com wrote:

Hmm... Pull request contains empty file...


Reply to this email directly or view it on GitHub.

@buildhive
Copy link

Jenkins » rebuild-plugin #66 SUCCESS
This pull request looks good
(what's this?)

@hrmohr
Copy link
Contributor Author

hrmohr commented Oct 7, 2013

My bad. Forgot to add the file to the index after I created the branch. Duh. The actual file is added now.

Looks like this plugin is more actively maintained than the maven metadata plugin, so I think it's ok to build support into this?

@oleg-nenashev
Copy link
Member

Agreed. We will merge existing PRs soon

shemeersulaiman added a commit that referenced this pull request Nov 15, 2013
[JENKINS-19910] added support for maven metadata plugin
@shemeersulaiman shemeersulaiman merged commit 8b190f7 into jenkinsci:master Nov 15, 2013
@hrmohr hrmohr deleted the JENKINS-19910 branch November 15, 2013 06:35
@oleg-nenashev
Copy link
Member

@shemeersulaiman and @ikedam
What about the new release? Several useful features hang in the master branch

@ikedam
Copy link
Member

ikedam commented Jan 8, 2014

I don't have commit access to rebuild-plugin.

@shemeersulaiman
Copy link
Member

We will release the plugin soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants