Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-74732 - Move jelly inline event handlers and script blocks to JavaScript. #76

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

asimell
Copy link
Contributor

@asimell asimell commented Nov 1, 2024

  • Moved all onclick handlers and script blocks to robot.js
  • Renamed .expand and .collapse classes to specifically pinpoint this plugin to avoid any possible errors with other plugins.

@asimell asimell requested a review from Tattoo November 1, 2024 13:37
Copy link
Member

@Tattoo Tattoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

src/main/webapp/robot.js Outdated Show resolved Hide resolved
Copy link
Member

@Tattoo Tattoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@asimell asimell merged commit cd4cde3 into master Nov 4, 2024
17 checks passed
@asimell asimell deleted the csp-jelly-fixes branch November 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants