JENKINS-72538 - SKIP status configurable when calculating all tests
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tattoo
reviewed
Nov 13, 2024
src/test/java/hudson/plugins/robot/tokens/RobotPassRatioTokenMacroTest.java
Show resolved
Hide resolved
src/test/java/hudson/plugins/robot/tokens/RobotPassPercentageTokenMacroTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
add // TODO: remove test when criticality is removed to line 61
| #robot-summary-table .fail { | ||
| color: #f00; | ||
| } | ||
| #robot-summary-table .pass { |
There was a problem hiding this comment.
should we have yellow color here as well?
There was a problem hiding this comment.
This class is only used for the font colour in the summary table. Of course we could add a yellow colour in the skipped column if any tests were skipped, but then again we could also take colouring off the table altogether?
src/main/resources/hudson/plugins/robot/RobotStep/config.properties
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/plugins/robot/RobotPublisher/config.properties
Outdated
Show resolved
Hide resolved
…properties Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…est.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…acroTest.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…okenMacroTest.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…rties Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Tattoo
approved these changes
Nov 13, 2024
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onlyCriticalflag. It no longer does anything, but is still kept to keep existing pipelines alive.getCriticalPassedandgetCriticalFailedfunctions. They will now just return overall passed/failed test cases.countSkippedTeststhat either ignores skipped tests when calculating pass percentage (current behaviour) or takes them into account (new behaviour)