[JENKINS-39414] - Update Stapler JRuby dependency to prevent binary compat issue in Jenkins 2.28+ #4
Conversation
…ompat issue in Jenkins 2.28+
|
Build timeout, weak 😦 |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Increased timeout |
| @@ -15,7 +15,7 @@ | |||
| <dependency> | |||
| <groupId>org.kohsuke.stapler</groupId> | |||
| <artifactId>stapler-jruby</artifactId> | |||
| <version>1.229</version> | |||
| <version>1.246</version> | |||
There was a problem hiding this comment.
would this work when running on an older Jenkins core with older stapler?
There was a problem hiding this comment.
At least it works on my small test instance
|
🐝 |
|
the build hangs somewhere |
|
🐝 not sure about the build |
|
IMHO this fix requires plenty of compatibility testing on older versions. My advice is to go forward with jenkinsci/stapler#85 and leave this guy for a while |
|
@oleg-nenashev Are we sure this is the correct repo, and not this? |
|
Yes, wrong repo. Should be tombstoned or even deleted |
Stapler 1.246 introduced new APIs, and unfortunately this APIs do not work correctly with outdated modules of stapler like Stapler JRuby. It caused a blocker regression for updating users (see JENKINS-39414).
Fix/hack on the stapler side: jenkinsci/stapler#85
@reviewbybees @jenkinsci/code-reviewers