-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lib.form.hetero-list.hetero-list #228
Conversation
@car-roll Does this work both before/after jenkinsci/jenkins#8418, or do we need to bump the minimum Jenkins version at the same time? |
@dwnusbaum ah you're right, I would probably need to bump. |
@@ -56,7 +56,7 @@ | |||
|
|||
<properties> | |||
<changelist>999999-SNAPSHOT</changelist> | |||
<jenkins.version>2.361.4</jenkins.version> | |||
<jenkins.version>2.426</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change was introduced in 2.422, chose the (soon-to-be) next LTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird though that instead of doing a quick backwards compatibility fix in core, all plugins needs to be fixed.
See jenkinsci/jenkins#8418 (comment)
hetero-list adjunct was removed in jenkinsci/jenkins#8418
If this adjunct gets called, a large stack trace error should appear in the logs.
Testing done
Tested under a local instance using a github multibranch folder but have not been able to extract any errors and was able to generate an error. This PR + jenkinsci/branch-api-plugin#415
Submitter checklist