Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lib.form.hetero-list.hetero-list #228

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Nov 6, 2023

See jenkinsci/jenkins#8418 (comment)

hetero-list adjunct was removed in jenkinsci/jenkins#8418
If this adjunct gets called, a large stack trace error should appear in the logs.

Testing done

Tested under a local instance using a github multibranch folder but have not been able to extract any errors and was able to generate an error. This PR + jenkinsci/branch-api-plugin#415

Submitter checklist

@car-roll car-roll requested a review from a team as a code owner November 6, 2023 23:16
@dwnusbaum
Copy link
Member

@car-roll Does this work both before/after jenkinsci/jenkins#8418, or do we need to bump the minimum Jenkins version at the same time?

@car-roll
Copy link
Contributor Author

car-roll commented Nov 7, 2023

@dwnusbaum ah you're right, I would probably need to bump.

@@ -56,7 +56,7 @@

<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.361.4</jenkins.version>
<jenkins.version>2.426</jenkins.version>
Copy link
Contributor Author

@car-roll car-roll Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change was introduced in 2.422, chose the (soon-to-be) next LTS

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird though that instead of doing a quick backwards compatibility fix in core, all plugins needs to be fixed.

@car-roll car-roll added the bug label Nov 8, 2023
@car-roll car-roll added this pull request to the merge queue Nov 8, 2023
Merged via the queue into jenkinsci:master with commit b16722f Nov 8, 2023
14 checks passed
@car-roll car-roll deleted the remove-adjunct branch November 8, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants