Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the plugin Java 11 ready -- Remove JAXB usage #63

Merged
merged 7 commits into from
Mar 21, 2019
Merged

Make the plugin Java 11 ready -- Remove JAXB usage #63

merged 7 commits into from
Mar 21, 2019

Conversation

batmat
Copy link
Member

@batmat batmat commented Mar 21, 2019 •
edited
Loading

mvn -V clean verify -Djenkins.version=2.164.1 works with this fix, both on a JDK8 and JDK11.

@jenkinsci/java11-support

@batmat
Bump to Java 8 min, so building with Jenkins 2.164 works
17270dc 
`mvn -V clean verify -Djenkins.version=2.164.1` works with this fix.
@batmat
Copy link
Member Author

batmat commented Mar 21, 2019

infra issue...

@batmat batmat closed this Mar 21, 2019
@batmat batmat reopened this Mar 21, 2019
@batmat
Fix FindBugs failure
c7471f5 
```
INFO] --- spotbugs-maven-plugin:3.1.11:check (spotbugs) @ scm-api ---
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[ERROR] jenkins.scm.impl.form.NamedArrayList doesn't override java.util.ArrayList.equals(Object) [jenkins.scm.impl.form.NamedArrayList] At NamedArrayList.java:[line 1] EQ_DOESNT_OVERRIDE_EQUALS
[INFO]
```
@batmat batmat changed the title [WIP] Bump to Java 8 min, so building with Jenkins 2.164 works Make the plugin Java 11 ready -- Remove JAXB usage Mar 21, 2019
@batmat
Copy link
Member Author

batmat commented Mar 21, 2019

@stephenc It is ready for your review, and hopefully approval & merge :). Thanks!

@batmat
Copy link
Member Author

batmat commented Mar 21, 2019

This will also fix https://issues.jenkins-ci.org/browse/JENKINS-56622

stephenc
stephenc requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@stephenc stephenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next version needs to have at least a minor bump

pom.xml Outdated Show resolved Hide resolved
@batmat
Bumping next version as requested by maintainer
3046df1 
@stephenc is requesting this to signal the fact the next version might
be slightly more than just a minor one in terms of risk, I gather.
@batmat
Merge remote-tracking branch 'origin/master' into java11-readiness
59801ae 
# Conflicts:
#	pom.xml
@batmat
Copy link
Member Author

batmat commented Mar 21, 2019

@stephenc comment addressed, and conflict with master fixed.

@stephenc stephenc merged commit bbf9667 into jenkinsci:master Mar 21, 2019
@batmat batmat deleted the java11-readiness branch March 21, 2019 14:47
@batmat
Copy link
Member Author

batmat commented Mar 21, 2019

Thanks Stephen!

@drdamour
Copy link

@stephenc i think the release notes on https://plugins.jenkins.io/scm-api have a typo they say required 2.160.3 not 2.60.3

@drdamour
Copy link

Screen Shot 2019-03-26 at 6 47 09 PM

@jetersen
Copy link
Member

jetersen commented Mar 27, 2019 •
edited
Loading

@drdamour anyone can fix that typo as long as you have a Jenkins account. https://accounts.jenkins.io/signup

On the plugins page to the right you should see the text: ARE YOU MAINTAINING THIS PLUGIN? Visit the Jenkins Plugin Wiki to edit this content.
The link takes you to https://wiki.jenkins.io/display/JENKINS/SCM+API+Plugin

Where you can sign in with your Jenkins account

However I have fixed the typo for now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jetersen jetersen jetersen approved these changes

@stephenc stephenc stephenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@batmat @drdamour @jetersen @stephenc @oleg-nenashev