Don't fail SCMName detection on non-IDN host names #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when passing an URL with a host name that is not a valid IDN to SCMName::from, it failed with an IllegalArgumentException. This especially affects the case when the host name is an IP address. Make this method a bit more graceful by returning null instead.
MarkEWaite
approved these changes
May 30, 2019
|
The CI failure is due to a JDK 11 javadoc problem on the master branch which will be resolved when #66 is merged. |
bitwiseman
approved these changes
Jun 14, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when passing an URL with a host name that is not a valid IDN to SCMName::from, it failed with an IllegalArgumentException. This especially affects the case when the host name is an IP address. Make this method a bit more graceful by returning null instead.