JENKINS-73941 - ForceSandbox - Align Script-Security plugin with preexisting behavior in Workflow-CPS plugin

[jgarciacloudbees]

JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system

Related to

• JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system #584
• JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system workflow-cps-plugin#948

In #584 we implemented the new forceSandbox logic in the Script Security Plugin instead of the Workflow-CPS Plugin.

The specific SandBox implementations are managed in the specific plugins, and in WorkflowCPS there are some functionalities not properly migrated in the previous PR to this repo

When the ForceSandbox option is enabled in the system:

• In WorkFlow-CPS, when a preexistent Pipeline has the sandBox disabled, a nonAdmin user can't edit it (the plugin is throwing an exception)
• In the Script-Security-Plugin, we have a Sandbox template implemented in org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript, but this behavior was not migrated, so when a preexistent Pipeline has the sandBox disabled, a nonAdmin user can edit it.

We have aligned both behaviors.

In addition, for admin users, when running the FormValidation, we haven't changed the behavior (the ForceSandbox does not apply to admin), but we have added in the message some information about Sandbox not allowed in the system.

Testing done

New test cases were included to cover the described changes.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue