SIGN-6984 - allow to store Api Token in global and system scope #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionally to CredentialsScope.SYSTEM
paulsavoie
reviewed
Jun 24, 2024
README.md
Outdated
| 1. Store the **Trusted Build System Token** in a System Credential (Under Manage Jenkins / Manage Credentials) | ||
| 2. Store the API Token(s) in a System Credential so that it is available to the build pipelines of the respective projects | ||
| 1. Store the **Trusted Build System Token** in a System Credential (Under Manage Jenkins / Manage Credentials) with the id `SignPath.TrustedBuildSystemToken` | ||
| 2. Store the API Token(s) in a System Credential so that it is available to the build pipelines of the respective projects (default id `SignPath.ApiToken`) |
There was a problem hiding this comment.
That change comes from me, right? We should probably say "credential" instead of "System credential"
There was a problem hiding this comment.
That was in the commit which you asked me to cherry-pick
Fixed
| String scopeName = scope == null ? "<null>" : scope.getDisplayName(); | ||
| CredentialsScope credentialScope = credential.getScope(); | ||
|
|
||
| if (allowedScopes.length > 0 && !Arrays.asList(allowedScopes).contains(credentialScope)) { |
There was a problem hiding this comment.
Is the allowedScope.length > 0 actually necessary?
There was a problem hiding this comment.
If allowedScope is empty there is no scope restriction
Updated readme
…path-plugin into feature/SIGN-6984
paulsavoie
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to store Api Token in global and system scope
Submitter checklist