Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGN-7090 - updated changelist and version to setup automatic release process #25

Merged
merged 7 commits into from
Oct 5, 2024

Conversation

volbobvol
Copy link
Contributor

SIGN-7090 - updated changelist and version in the POM file to setup automatic release process

Submitter checklist

  • [ x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ x ] Ensure that the pull request title represents the desired changelog entry
  • [ x ] Please describe what you did
  • [ x ] Link to relevant issues in GitHub or Jira

pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
<packaging>hpi</packaging>
<properties>
<revision>2.0.1</revision>
<changelist></changelist>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.359</jenkins.version>
<java.level>11</java.level>
Copy link
Member

@timja timja Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional)

these shouldn't be overridden unless you really know what you are doing.
line 18-22 I think could probably be deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one more commit here
ba9ad3d

The goal is to have a manually controlled version prefix and auto-increment for the build number.

volbobvol and others added 3 commits October 4, 2024 16:13
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another commit to fixup something else but LGTM

@volbobvol volbobvol merged commit 28145c6 into main Oct 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants