Clarify the messaging around the failure notification options

[sghill]

I noticed issue #518 came up today. It has also been a point of confusion for me in the past. I think clarifying the wording and moving the repeated failure option out of advanced could help.

I think overall I'd prefer just having one "notify on every failure" option, but this would be a nice improvement too.

[timja]

Lol I just commented on your PR saying there should be one on every failure.

[sghill]

Would you want a third option, or replace these two with a notify on every failure?

I think ideally I'd like to have something higher level I could configure - like 'everything but repeated success' or 'everything'

[timja]

third one for now, can potentially remove the other two,
I think the third one could go in the main section and the other two in advanced

and see how that works for people

what i have at work in pipeline is: every failure and fixed

[medianick]

A minor quibble (especially as this is merged already), but having two options with "Only" in them as checkboxes -- suggesting that they're mutually exclusive, but allowing both to be selected -- seems confusing. I'd remove the word "Only" from both, and ideally reword these as "Notify for first failure" (or "Notify for initial failure") and "Notify for repeated failures". You could also use "upon" instead of "for".

[jetersen]

@medianick see my comment in #520 (comment)