Fix matrix-project hard dependency #558
Conversation
Missed a call to matrix-project compile time dependency before
| @@ -154,7 +153,7 @@ public void completed(AbstractBuild r) { | |||
| } | |||
|
|
|||
| private boolean skipOnMatrixChildren(AbstractBuild build) { | |||
| return build instanceof MatrixRun && !notifier.getMatrixTriggerMode().forChild; | |||
| return notifier.isMatrixProject(build) && !notifier.getMatrixTriggerMode().forChild; | |||
There was a problem hiding this comment.
You're missing the other problem, getMatrixTriggerMode can return null 😆
private MatrixTriggerMode matrixTriggerMode = MatrixTriggerMode.ONLY_CONFIGURATIONS;
Does nothing when reading from XML.
There is no need for having it set on non-Matrix jobs either.
There was a problem hiding this comment.
Give me commit access than I have a fix for that 😅
There was a problem hiding this comment.
I swear the tests worked before I merged it with yours 🤣
There was a problem hiding this comment.
[2019-04-15T13:22:06.034Z] [ERROR] Possible null pointer dereference in jenkins.plugins.slack.ActiveNotifier.skipOnMatrixChildren(AbstractBuild) due to return value of called method [jenkins.plugins.slack.ActiveNotifier, jenkins.plugins.slack.ActiveNotifier] Dereferenced at ActiveNotifier.java:[line 157]Known null at ActiveNotifier.java:[line 157] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
There was a problem hiding this comment.
I hate mocking! The isMatrixRun is being mocked out...
There was a problem hiding this comment.
SpotBugs on my end does not complain 😕
There was a problem hiding this comment.
fails for me with
mvn spotbugs:check
|
As soon as I commented! GitHub figured it out 🤔 |
|
|
Missed a call to matrix-project compile time dependency before
Closes #557