Fix concurrent build back to normal notification missed #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue where previous build could also be current build if multiple builds were running concurrently
timja
reviewed
May 29, 2019
| @@ -134,7 +134,7 @@ public void completed(AbstractBuild r) { | |||
| if (null != previousBuild) { | |||
| do { | |||
| previousBuild = previousBuild.getPreviousCompletedBuild(); | |||
| } while (null != previousBuild && previousBuild.getResult() == Result.ABORTED); | |||
| } while ((null != previousBuild && previousBuild.getResult() == Result.ABORTED) || previousBuild.getNumber() == r.getNumber()); | |||
There was a problem hiding this comment.
seems ok, have you tested it out?
There was a problem hiding this comment.
Yep, I was able to reproduce the error on the local Jenkins instance created by running the plugin. I confirmed that when I made my change the notification properly showed up as well as logging the last build properly, fixing #568 too.
I'll check out the failing build and push more changes if need be.
timja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544
Added a check to make sure that the same builds aren't being compared with each other.
It seems like when two concurrent builds are happening, the context for the
projectvariable gets changed so theproject.getLastBuild()ends up returning the newest build even thoughris still the earlier of the two. This makesrandpreviousBuildrefer to the same build and break theOnBackToNormalcheck.