Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WebApp#mimeTypes #564

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Deprecate WebApp#mimeTypes #564

merged 1 commit into from
Jul 2, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jul 1, 2024

In practice this map is always empty, since I checked Jenkins and CloudBees sources and nothing ever writes to the map. The only reader besides Stapler is https://github.com/jenkinsci/scm-api-plugin/blob/a24e62fa67977d1c381b922a1a745afb725771c7/src/main/java/jenkins/scm/api/SCMFile.java#L422. Altogether I can't see a good reason to retain this feature; the servlet container should always be the source of truth and this seems like yet another case of Stapler over-reaching in scope. Simpler to deprecate this feature and remove it eventually.

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the internal label Jul 1, 2024
@basil basil merged commit 58b27c4 into jenkinsci:master Jul 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants