PCT: Adapt test for 2.340 structure changes #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Mar 26, 2022
| @@ -276,7 +277,11 @@ public static void testPermissionToSeeAction(JenkinsRule j, | |||
| HtmlPage page = wc.goTo(baseUrl); | |||
| HtmlDivision sidePanel = (HtmlDivision) page.getElementById("side-panel"); | |||
| assertEquals(userPrivileged + " should be able to see the Support action", 1, | |||
| sidePanel.getElementsByAttribute("a", "title", action.getDisplayName()).size()); | |||
There was a problem hiding this comment.
title attribute is no longer set, just iterate through instead, could switch to xpath too but this is quite straightforward
|
Passed in bom jenkinsci/bom#960 |
Dohbedoh
approved these changes
Mar 28, 2022
|
the windows CI failed on |
|
@timja finally went through: https://github.com/jenkinsci/support-core-plugin/releases/tag/1148.vedff8cb_56a_da_ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for jenkinsci/bom#955 and jenkinsci/bom#960
Can we get a release please?