Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite when getting files #152

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Overwrite when getting files #152

merged 2 commits into from
Jun 27, 2017

Conversation

pescuma
Copy link
Contributor

@pescuma pescuma commented Mar 2, 2017

To avoid problems when files are changed during the build.

@mosabua
Copy link
Member

mosabua commented Mar 2, 2017

Should this maybe be an option ?

@pescuma
Copy link
Contributor Author

pescuma commented Mar 2, 2017

Is there any problem if it always override? I'd find it strange if one build depends on the changes made by the previous one, but maybe I'm missing something.

@mosabua
Copy link
Member

mosabua commented Mar 2, 2017

I am not sure. But we are changing current behavior of the plugin so it might be safer as an option. No idea what all our users are up to.. but I do like the idea of having this overwrite behaviour.

@jpricket
Copy link
Contributor

Hi @pescuma, I agree with @mosabua that this should probably be a global option. At least then users can change the behavior back if there is some kind of problem. The default should probably be for it to overwrite as you have suggested.
Thanks,
Jason

@pescuma
Copy link
Contributor Author

pescuma commented Jun 26, 2017

I've agreed with @mosabua and I intended to implement this as a build option, but it kind of got lost. I'll create that option.

@pescuma
Copy link
Contributor Author

pescuma commented Jun 27, 2017

@jpricketMSFT @mosabua Done

@mosabua
Copy link
Member

mosabua commented Jun 27, 2017

I like it. Imho we should merge.

Copy link
Contributor

@jpricket jpricket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jpricket jpricket merged commit 8b9d691 into jenkinsci:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants