Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return version history without cloacked paths when listing for build #153

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Return version history without cloacked paths when listing for build #153

merged 1 commit into from
Jun 27, 2017

Conversation

pescuma
Copy link
Contributor

@pescuma pescuma commented Mar 2, 2017

No description provided.

@jpricket
Copy link
Contributor

Hi @pescuma, can you explain why you would want this done and why you think everyone would want this change?
Thanks,
Jason

@pescuma
Copy link
Contributor Author

pescuma commented Jun 26, 2017

Hi @jpricketMSFT . I think that it makes sense that, if you don't want to see the contents of one folder, you also don't want to see changes in that folder, but maybe I'm influenced by how we use TFS here. Here, we have some projects inside $/ (let's say $/A , $/B and $/C) and, sometimes, to compile one you also need to compile another (let's say $/B depends on $/A). So, because we can't checkout 2 paths, I cloack the paths that are not interesting for a build (in our example, I'd download $/ and cloack $/C). So, when checking which revisions were compiled, I'm not interested in seeing revisions for $/C.

@jpricket
Copy link
Contributor

Hi @pescuma, Thanks for the explanation. That makes sense. I will review the code this week and provide any feedback I have.
Thanks,
Jason

@jpricket
Copy link
Contributor

@pescuma - The changes look good to me. Can you fix the conflicts and push a new commit?
Thanks for this contribution!

@pescuma
Copy link
Contributor Author

pescuma commented Jun 27, 2017

@jpricketMSFT Done

@jpricket jpricket merged commit aa1c3da into jenkinsci:master Jun 27, 2017
@pescuma pescuma deleted the cloacked_history branch July 4, 2017 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants