[JENKINS-54578] Cannot delete last category #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was impossible to delete all categories (neither at once nor one by one), since when not receiving any categories, the last-saved categories took precedence. This has been solved by initializing the categories property when not receiving the categories from the configuration form.
aeoris
force-pushed
the
JENKINS-54578
branch
from
869eff2
to
0932cfa
Compare
oleg-nenashev
requested changes
Nov 18, 2018
There was a problem hiding this comment.
Thanks @aeoris! Most likely it is better to update Jelly forms to prevent it, but it should work... Requesting the changes, because Hamcrest dependencies are not scoped to test
basil
approved these changes
Dec 13, 2019
basil
changed the title
|
Thanks for your contribution, @aeoris! I just merged your PR with
This should be a part of the forthcoming Throttle Concurrent Builds 2.0.2 release. Thanks again! |
|
Released in Throttle Concurrent Builds 2.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was impossible to delete all categories (neither at once nor one by
one), since when not receiving any categories, the last-saved categories
took precedence. This has been solved by initializing the categories
property when not receiving the categories from the configuration form.