Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #64

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Test cleanup #64

merged 4 commits into from
Nov 21, 2019

Conversation

basil
Copy link
Member

@basil basil commented Nov 21, 2019

Now that the plugin POM is up-to-date and the CI system is running tests on both Jenkins 2.60.3 and Jenkins 2.164.1 (a recent LTS release), let's start cleaning up the tests in preparation for some future changes. This will give us a solid baseline to measure future changes against.

This PR makes the following changes to tests:

  • Migrate from deprecated HudsonTestCase to JenkinsRule
  • Migrate from deprecated @Bug to @Issue
  • Remove unnecessary throws declarations in tests
  • Simplify JUnit assertions

@basil basil merged commit c1aa0f9 into jenkinsci:master Nov 21, 2019
@basil basil deleted the testCleanup branch December 13, 2019 23:01
@basil basil added the test label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant