Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce DAYS_SINCE_PROJECT_START #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dss539
Copy link

@dss539 dss539 commented Nov 9, 2015

credit to @felegy for the changes

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@DenizThatMenace
Copy link
Contributor

Hello Derrick,
sorry for the late response. I somehow missed the github-notification and your e-mail as-well.

Your changes seem to work and are a useful extension to the plugin.
However, in order to not being overlooked, the new feature should have some kind of documentation/help. At least it should be mentioned in the help that gets displayed when clicking the little ?-icon next to the appropriate option. Some tests are always good, too.

So, before accepting your pull-request, I recommend you add the appropriate documentation and a small test-case. The files you need to edit for this are already existent and you should easily determine how to add the documentation and test.

Additionally, I would like you to squash all your changes into a single commit.
For information about how to do this you can look here.

Thanks,
Deniz

@dss539
Copy link
Author

dss539 commented Feb 18, 2016

Hi Deniz,

I'll try to address your concerns after I set up an java dev environment.
Thanks for responding, I'll put this on my TODO list.

Best Regards,
Derrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants