-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize the plugin to java 11 #26
Conversation
pom.xml
Outdated
~ hpi-plugin.version: The HPI Maven Plugin version used by the plugin.. | ||
~ stapler-plugin.version: The Stapler Maven plugin version required by the plugin. | ||
--> | ||
<java.level>8</java.level> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most recent parent pom no longer requires java.level
. I've updated the document to show that correction.
<java.level>8</java.level> |
Thanks very much! When I use your change, there is a test that fails if I run Would you also be willing to add a Jenkinsfile in the pull request so that a job will be available on ci.jenkins.io to monitor this repository? |
@AayushSaini101 I'd be very grateful if you'd be willing to experiment with the tutorial that is being assembled from the "Contributing to Open Source" document. The tutorial pull request is available at jenkins-infra/jenkins.io#4806 . When the pull request build completes, a preview of the tutorial will be available at https://deploy-preview-4806--jenkins-io-site-pr.netlify.app/doc/developer/ in the section labeled "Improve a Plugin - Tutorial". We expect that the tutorial will have completed review and will be live on https://www.jenkins.io/doc/developer/ before the end of September 2022. |
|
Thanks for sharing the example. I see the same success on Windows as you see. When I run the tests on a Red Hat Enterprise Linux 8.6 with Java 11.0.16.1, I see the test failure. When I run on a Debian machine, I don't see the test failure. I can't explain why that test would be platform specific. That is quite surprising. Do you mind if I push the bill of materials change to this branch as a check to confirm that resolves the issue that I am seeing? The removal of |
Sure, sir, You can push the bill of materials. |
Simplify the management of plugin versions for tests by using the plugin bill of materials to provide version numbers for the test dependencies. Require Jenkins 2.332.4 because it is a recommended version from https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
Test JDK 8, JDK 11, and JDK 17
Modernize the plugin to java 11.