Fix NodeProperties config on vSphere template #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config UI is getting way too wide - if we use shorter title text for fields then it'll leave more space for the data and won't be so scrunched up.
Plugin version now set from properties in pom.xml. Changed Jenkins.getActiveInstance() to Jenkins.getInstance().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing config WebUI doesn't list all possible node properties, limiting what folks can enter. It should allow folks to specify any node properties that are suitable for the vSphere nodes.
This code change lets you add any node properties to a vSphere template.
It also fixes (well, bypasses) the problem whereby the existing configured node properties don't get loaded into the WebUI properly such that, unless the user re-enters them, they'll get wiped on save (not sure why that was happening, but this code change stops it happening).
This will resolve JENKINS-41428 and JENKINS-46375.