Fix Jenkins 61702 #118
Fix Jenkins 61702 #118
Conversation
It shouldn't need a descriptor visibility filter as it says isInstantiable=false. It can remove most descriptor code just by inheriting from vSphereCloudSlave's descriptor instead.
It shouldn't need a descriptor visibility filter as should be visible. It doesn't need to specify isInstantiable=true as that's the default.
Don't call getComputerLauncherDescriptors() as that doesn't exist anymore, call computerLauncherDescriptors(it) instead.
Uses the same code pattern as used in DumbSlave in the core code.
pjdarton
added
WIP
|
The original jenkinsci build failed because of infrastructure reasons (one AWS node died shortly after the build had successfully built, but before Jenkins had let it go, so the node death flagged the build as a failure). To anyone watching this, it's a good idea to check the details of a "failed" build, as they're often unrelated to the code being built. |
|
This is now awaiting "someone other than me" to test that it fixes the issue it's meant to. However, once we've got positive confirmation (either here or on the JIRA issue) from someone who was hitting this problem that they've tried it and it fixes the issue, I'll be happy to merge it it and it can then go into the next release. |
| public boolean isInstantiable() { | ||
| /* | ||
| * This type of agent can't be directly created by the user through the UI. | ||
| * The user defines a vSphere agent template and _that_ then creates these "on demand". | ||
| */ | ||
| return false; |
There was a problem hiding this comment.
I think we are fine as long as this is kept in. This is meant to prevent JCasC from removing dynamically provisioned nodes from vSphere.
|
Feedback from JENKINS-61702 is that this PR fixes the bug. |
After 2.21, we (accidentally) lost the ability to manually create vSphere nodes from the UI.
See https://issues.jenkins-ci.org/browse/JENKINS-61702
Oops.
This is an attempt to solve that.