Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change version of yavijava that we fetch from 6.0.03 to 6.0.04. #46

Merged
merged 2 commits into from
Sep 7, 2016
Merged

Change version of yavijava that we fetch from 6.0.03 to 6.0.04. #46

merged 2 commits into from
Sep 7, 2016

Conversation

pjdarton
Copy link
Member

@pjdarton pjdarton commented Sep 7, 2016

@pjdarton
Change version of yavijava that we fetch from 6.0.03 to 6.0.04.
3c74cde 
This fixes yavijava/yavijava#153 which fixes
https://issues.jenkins-ci.org/browse/JENKINS-37888
@pjdarton
Fix Javadoc warnings and errors - no functional changes.
c604186 
Added missing javadoc fields to vSphereCloud.java's
DescriptorImpl.doTestConnection.
Removed unused imports from VSphereBuildStep.java.
Escaped <> around email address in @author tag in
VSphereConnectionConfig.java.
Added missing tags, removed unused tags, and added description text in
VSphere.java.
Added missing javadoc fields to VSphereLogger.java.
@pjdarton
Copy link
Member Author

pjdarton commented Sep 7, 2016

Note:
Before I submitted this pull request, the last build on https://jenkins.ci.cloudbees.com/job/plugins/job/vsphere-cloud-plugin/ used Java 7 to build the plugin.
I made my one-character change to the pom.xml (3c74cde) and the resulting build failed with Javadoc errors, and I noticed that it had rebuilt using Java 8 (which has more stringent Javadoc checking than Java 7).
So I've tidied the Javadoc up such that it passes Java 8 Javadoc parsing, but I did not deliberately (or knowingly) change from Java 7 to Java 8, so either that's an unanticipated side-effect of moving to the latest yavijava or (more likely) cloudbees has upgraded to Java 8 within the last few months.

@jswager jswager merged commit bf93c21 into jenkinsci:master Sep 7, 2016
@pjdarton pjdarton deleted the fix_jenkins_37888 branch September 7, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pjdarton @jswager