[JENKINS-44796] Recognize VMs that our Jenkins created and permit reconnection. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have previously lost contact with vSphere and thus end up with VMs that are not known to Jenkins, but later we attempt to create a slave whose same-named VM already exists, we can now recognise this situation and reconnect. Previously the code would repeatedly fail to create the VM and be unable to spawn new VMs as a result.
pjdarton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have previously lost contact with vSphere and thus end up with VMs
that are not known to Jenkins, but later we attempt to create a slave whose
same-named VM already exists, we can now recognize this situation and
reconnect.
Previously the code would repeatedly fail to create the VM and be unable to
spawn new VMs as a result.