Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button text in folder configuration #99

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

albers
Copy link
Member

@albers albers commented Oct 24, 2018

On the folder configuration page, the button for adding a cloud is wrongly labelled Add vSphere Template, see

add-vsphere-template

The button for adding a cloud is wrongly labelled Add vSphere Template".

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@pjdarton pjdarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.
(I don't use folders much, so I never noticed this)

@pjdarton pjdarton merged commit 142dafe into jenkinsci:master Oct 24, 2018
@albers
Copy link
Member Author

albers commented Oct 24, 2018

@pjdarton Does a folder-level cloud & template configuration work for you?

If I define both at this level, the node labels associated with the templates are not recognized.
The job configurations do no even show a "Restrict where this project can be run" checkbox.

I have to define the cloud and templates in the global configuration.

@albers albers deleted the fix-button-text branch October 24, 2018 13:52
@pjdarton
Copy link
Member

I don't use folder-level configuration at all where I work; I only use global configuration.

I was not involved when this "Folder" functionality was added and cannot comment on what features or functionality it was intended to add, and hence have no idea if it solved the problems that the author (of that feature) intended it to solve.
My (limited) understanding of the folder plugin is that it's of limited use on its own and is only fully functional as the (non-free) folders plus plugin. As I only use the free Jenkins stuff at work, I've never fully explored what problems the non-free functionality is meant to solve.
My assumption was that the support for folders that was added to this plugin would be useful with both the free and the non-free folder code, but written in a way that did not prevent the plugin from working without either.

All I know for sure is that it didn't break everything else :-)

If your jobs are missing a "Restrict where this project can be run" checkbox then that's a separate issue; I do not believe that it'll have anything to do with this plugin (maybe it might be related to how you're using the folders plugin, or maybe something else).
I'd suggest that you try defining a normal "general purpose" job, both at the top level and within folders, and setting "Restrict where this project can be run" in there. I'd also suggest that you enable lots of logging and see what Jenkins is asking the vSphere plugin to do when you ask it to run a build.

@albers
Copy link
Member Author

albers commented Oct 26, 2018

One of the features of the folders plus plugin is "restrict the use of slaves to specific folders". Probably this also affects the cloud plugins and therefore vSphere when used with the basic folders plugin.

If your jobs are missing a "Restrict where this project can be run" checkbox then that's a separate issue; I do not believe that it'll have anything to do with this plugin

Assuming that per folder cloud configuration only works with the folders plus plugin, this is expected behaviour: The checkbox is hidden unless agents are configured. If the folder level cloud configuration is ignored, no agents are configured and no restriction on where to run the job can be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants