-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow explicit selection of default library tag. #116
base: master
Are you sure you want to change the base?
Conversation
If developer manually specifies the default version of a library where overriding the default version is not allowed, this should allow the checkout to proceed normally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to go this route as it can cause more confusion for users that are not aware of this behavior. At the very least there needs to be some logging to explain that this has happened and possibly even a flag to enable this behavior.
Hello @car-roll - I have added logging as you suggested. I'm not familiar enough with the codebase to know how I might create a toggle/option for this functionality - could you give me a hint? Please LMK your thoughts. |
@dvpierce Something like this: https://github.com/jenkinsci/durable-task-plugin/blob/adeab44bbb208cdd3e375775eacd281e6e49797b/src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java#L69 You would then be able to set the variable in the jenkins command-line startup or via the script console. edit: For some reason, when I looked at it I was thinking this was more disruptive behavior than it really is. I'm now thinking a switch isn't necessary. |
As of #172 most of the code in this plugin has been moved to another plugin repository so this PR must be closed. If this change is still needed, please git clone https://github.com/jenkinsci/pipeline-groovy-lib-plugin
cd pipeline-groovy-lib-plugin
git checkout -b patch-1
git pull https://github.com/dvpierce/workflow-cps-global-lib-plugin patch-1 resolve any merge conflicts, and file a fresh PR on the new repository. Be sure to paste a link to this old PR to enable bidirectional navigation. |
If developer manually specifies the default version of a library where overriding the default version is not allowed, this should allow the checkout to proceed normally.
https://issues.jenkins.io/browse/JENKINS-66682