Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with Guice 7 #213

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jan 18, 2024

Without dropping compatibility with Guice 6 (currently delivered by Jenkins core), add support for Guice 7.

@basil basil requested a review from a team January 18, 2024 03:05
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already deprecated so I do not plan to bother replacing @Inject with ExtensionList.lookupSingleton.

@jglick jglick merged commit 55f2f80 into jenkinsci:master Jan 18, 2024
14 checks passed
@basil basil deleted the jakarta-inject branch January 18, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants