Never print warnings from CpsStepContext.completed, but use addSuppressed
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
approved these changes
May 18, 2022
|
Lots of test flakes in this plugin recently. Not sure if there has been some infrastructure change or what. |
|
Can cause a stack overflow error. |
|
I believe this is safe to release at any time. |
dwnusbaum
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amending #490, and a string of earlier attempts to log repeated attempts to mark a step as failed, all of which had problems. Most recently, in jenkinsci/workflow-durable-task-step-plugin#180 I find a case where first a
nodeblock is marked failed byFlowInterruptedException, and then a nestedshstep throwsMissingContextVariableExceptionas well. Harmless; can useaddSuppressedto at least track everything.