Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to enable/disable PowerShell profile #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ofosos
Copy link

@ofosos ofosos commented Apr 4, 2021

Hey,
I implemented an option to enable or disable loading of the PowerShell profile. This change doesn't affect the default behavior of the plugin (disable loading of profile). The test demonstrate how this can be used. Since it's hard to write a unit test for this, I relied on creating a PS script that would check if the NoProfile option was present in the current process. The changes to support this behavior are already merged upstream. I bumped the version in the pom for testing purposes, feel free to drop that commit.

Here's my checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Here's the relevant upstream PR:
jenkinsci/durable-task-plugin#130

Cheers, Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant