Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExecutorPickle add RemovedNodeCause #176

Merged
merged 7 commits into from
Nov 8, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 28, 2021

Downstream of jenkinsci/workflow-cps-plugin#473. Further refines #175 to use a specific CauseOfInterruption introduced in #104 for a related reason.

Before:

Resuming build at … after Jenkins restart
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
[Pipeline] End of Pipeline
ERROR: Killed part of p #1 after waiting for 15,000 ms because we assume unknown Node slave0 is never going to appear!
Finished: FAILURE

After:

Resuming build at … after Jenkins restart
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Waiting to resume part of p #1: ‘Jenkins’ doesn’t have label ‘slave0’
Killed part of p #1 after waiting for 15 sec because we assume unknown agent slave0 is never going to appear
[Pipeline] End of Pipeline
Agent was removed
Finished: ABORTED

@jglick jglick marked this pull request as ready for review November 5, 2021 20:08
@jglick jglick requested review from car-roll and dwnusbaum November 5, 2021 20:15
@car-roll car-roll merged commit 9e371d9 into jenkinsci:master Nov 8, 2021
@jglick jglick deleted the ExecutorPickle-RemovedNodeCause branch November 8, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants