Avoid deprecated api usage #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanoort
reviewed
Oct 30, 2018
| @@ -275,7 +275,10 @@ public WorkflowRun(WorkflowJob job, File dir) throws IOException { | |||
| if (!auth.equals(ACL.SYSTEM)) { | |||
| String name = auth.getName(); | |||
| if (!auth.equals(Jenkins.ANONYMOUS)) { | |||
| name = ModelHyperlinkNote.encodeTo(User.get(name)); | |||
| User user = User.getById(name, false); | |||
There was a problem hiding this comment.
This appears to be a separate fix... but a worthwhile one that avoids an NPE potentially.
svanoort
reviewed
Oct 30, 2018
| import java.io.IOException; | ||
| import java.io.PrintWriter; | ||
| import java.io.StringWriter; | ||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import jenkins.model.TransientActionFactory; | ||
| import org.apache.commons.io.IOUtils; |
There was a problem hiding this comment.
I'm a little confused -- were we somehow importing the wrong dependency here?
There was a problem hiding this comment.
Ah, explanation for context: we're just wrapping a call to the Commons IOUtils method, no point in doing that.
svanoort
approved these changes
Oct 30, 2018
dwnusbaum
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the analysis https://ci.jenkins.io/job/Infra/job/deprecated-usage-in-plugins/job/master/566/artifact/output/usage-by-plugin.html.